docs: quickstart tab lists Linux, Windows, Intel Mac; repoint CLI anchors#290
Merged
Conversation
…hors (#2147) Quickstart Web app tab label -> 'Web app (Linux, Windows, Intel Mac)', which shifts its deep-link anchor to #ok-install-web-app-linux-windows-intel-mac. Repointed all 5 CLI/install links (hero, CTA, mcp-install, packages/cli README, overlay README) to the new anchor and updated the tabs.test.ts assertion that pins it. Unit test green confirms the slug. GitOrigin-RevId: 614cd822e6146330ba819b82d9f2577729b416a5
…hors (#2140)
* fix(open-knowledge docs): teach validate-link about tab deep-link anchors
The `<Tabs updateAnchor>` machinery (src/components/tabs.tsx) writes
`#${composeTabId(label, groupId)}` per tab, but validate-link only derived
valid `#fragments` from `getTableOfContents` (headings). So any link to a tab
anchor — e.g. overview.mdx → `/docs/get-started/quickstart#ok-install-web-app-linux-intel-mac`
(added in #2132) — was false-flagged as `invalid-fragment`, turning the docs
build red on main and every open PR.
Register tab anchors into each page's valid hash set by parsing `<Tabs
items={[...]}>` and composing ids through the exported `composeTabId` — the
same single source of truth the runtime uses, so the validator can't drift
from the real anchor slugs.
* docs: drop inert dotAll flag on TABS_OPEN_TAG, fix flag attribution comment
Address PR review: the `s` flag on `TABS_OPEN_TAG` was inert — its capture
group is `[^>]*`, which matches newlines regardless of dotAll (dotAll only
affects `.`). The load-bearing `s` is on `ITEMS_ATTR`, whose `.*?` needs it to
cross newlines in a multi-line items array. Removed the no-op flag and
corrected the comment's attribution. Verified empirically and via
`bun run validate-link` (still 0 errors — no behavior change).
---------
GitOrigin-RevId: 0415406e9dc9c7236811b81e530a3f40b3a60eee
![inkeep-internal-ci[bot]](https://avatars.githubusercontent.com/in/2806322?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Automated approval from agents-private public-mirror-sync (run: https://github.com/inkeep/agents-private/actions/runs/28203916718). Source of truth is the monorepo; direct edits on inkeep/open-knowledge are overwritten on next sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.